Skip to content

chore: remove the JustDummies source from this repository - #411

Merged
Reefact merged 1 commit into
mainfrom
claude/french-responses-fbdmo6
Aug 7, 2026
Merged

chore: remove the JustDummies source from this repository#411
Reefact merged 1 commit into
mainfrom
claude/french-responses-fbdmo6

Conversation

@Reefact

@Reefact Reefact commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

Steps 5 and 6 of ADR-0069. The consumers moved to the published package in #410, so nothing here references these projects any more and deleting them breaks nothing — which is exactly the order ADR-0069 insists on, because the reverse turns every later step into a broken-build debugging session.

247 files, −43 661 lines.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Analyzer / diagnostic change
  • Tests
  • Documentation
  • Build / CI / tooling

Changes

Deleted

  • The seven JustDummies.* projects and their FirstClassErrors.sln entries (105 solution lines).
  • tools/justdummies-check/ and its .gitignore block.
  • The dum release train, everywhere it was spelled: tools/trains.sh, pack.sh, release.yml (trigger, dispatch choice, REF_NAME case, component allowlist, error texts), release-notes.sh, collect-prs.sh, changelog.yml.
  • The justdummies commit scope: lint-commit-message.sh, CONTRIBUTING.md, CLAUDE.md, dependabot-autofix.yml, dependabot-autofix-prompt.md.
  • build/stryker/justdummies{,-analyzers,-xunit}.json, justdummies.yml, justdummies-mutation.yml and its two reference pages.
  • WritingJustDummiesTests.{en,fr}.md and the dum tool specification (2 × ~2 200 lines), with their index entries.

Kept but rewritten — where the surrounding subject stays and only the JustDummies mention had to go: the mutation.yml header, the public-API baseline rationale, the workflows index, CLAUDE.md, AGENTS.md.

Two judgement calls worth reviewing

  • The pack.sh standalone guard goes with the train it guarded. It asserted that a shipped JustDummies package declares no FirstClassErrors dependency. That assertion still matters — it is now made in the repository that ships the package.
  • The net472 floor loop drops the three JustDummies suites and keeps three. Its comment said "exactly these six"; I updated the count rather than leaving it. A stale number in a comment is how the next reader learns to distrust the comments.

Testing

  • dotnet build FirstClassErrors.sln — 0 warnings, 0 errors
  • dotnet test FirstClassErrors.sln9 suites, 1046 tests, 0 failures
  • Analyzer tests pass (FirstClassErrors.Analyzers.UnitTests — 132)
  • All four modified workflows re-parsed as YAML; pack.sh, trains.sh, lint-commit-message.sh pass sh -n
  • trains.sh now lists exactly lib cli; commit-lint rejects feat(justdummies): and still accepts feat(core):

Not verified: the net472 floor leg. It aborts locally on Linux, and that job runs on windows-latest — CI is where it gets proven, not here.

Documentation

  • README / doc/ updated — the two maintainer indexes, the workflows index, CONTRIBUTING.md
  • French translation updated alongside the English page it mirrors — both README.fr.md files
  • Public API / analyzer documentation updated — no public surface changes

Architecture decisions

  • No architectural decision in this pull request — it executes Accepted ADR-0069.

The ADR sweep is deliberately not in this PR. ADR-0069 keeps ADR-0006, ADR-0011, ADR-0026 and ADR-0061; the other 33 that moved to Reefact/just-dummies go in a change of their own, because a tag has to mark the last commit carrying those records before they are removed, and several surviving ADRs cite them and need their links repointed at the renumbered files over there.

Related issues

Refs #404


Generated by Claude Code

@Reefact
Reefact force-pushed the claude/french-responses-fbdmo6 branch from 4e50759 to b122af2 Compare August 7, 2026 20:50
Repository owner deleted a comment from chatgpt-codex-connector Bot Aug 7, 2026
Steps 5 and 6 of ADR-0069, now that nothing here references those projects: the
consumers moved to the published package in the previous change, so deleting the
source breaks nothing.

Gone: the seven JustDummies.* projects and their solution entries,
tools/justdummies-check, the dum release train (trains.sh, pack.sh, release.yml,
release-dryrun.yml, release-notes.sh, collect-prs.sh, changelog.yml), the
justdummies commit scope, the three Stryker configurations, justdummies.yml,
justdummies-mutation.yml and its two reference pages, WritingJustDummiesTests,
and the dum tool specification.

The train had to be hunted by the bare word 'dum', not by 'JustDummies': three
callers spelled it only that way — release-dryrun.yml invoking pack.sh and
release-notes.sh, and changelog.yml's dispatch choice — and a sweep for the
product name leaves every one of them behind.

The pack.sh standalone guard goes with the train it guarded: it asserted that a
shipped JustDummies package declares no FirstClassErrors dependency, which is now
asserted in the repository that ships it.

The net472 floor loop drops the three JustDummies suites and keeps three. Its
comment said 'exactly these six'; a stale count in a comment is how the next
reader learns to distrust the comments.

Documentation that merely MENTIONED JustDummies is updated rather than deleted
where the surrounding subject stays — the mutation workflow header, the public-API
baseline rationale, the workflows index. The ADR sweep is deliberately not here:
it is its own change, and a tag has to mark the last commit carrying those records
before they go.

Refs: #404
@Reefact
Reefact force-pushed the claude/french-responses-fbdmo6 branch from b122af2 to 9666aa3 Compare August 7, 2026 20:52
@Reefact
Reefact merged commit 8b93270 into main Aug 7, 2026
24 checks passed
@Reefact
Reefact deleted the claude/french-responses-fbdmo6 branch August 7, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants